-
Notifications
You must be signed in to change notification settings - Fork 43
Add app version metadata to Project settings (fixes #167) #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ef839b2 to
f4bd802
Compare
|
Key points:
Happy to address any feedback! |
Bl3f
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just before we merge can you rebase on origin/main and also remove the FASTAPI_URL/PORT changes, they have been done on main already!
Thank for this
…em route, Application + MCP settings cards)
bb2bae2 to
a839c40
Compare
Bl3f
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few last changes.
| </SettingsCard> | ||
|
|
||
| {isAdmin && ( | ||
| <SettingsCard title='Application'> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of using inputs can you make the design flatter? I know we use input for project parameters, but it's because we might make them editable, where here it does not makes sense to edit.
| -e BETTER_AUTH_URL=http://localhost:5005 \ | ||
| -v /path/to/your/nao-project:/app/project \ | ||
| -e NAO_DEFAULT_PROJECT_PATH=/app/project \ | ||
| getnao/nao:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about this?
| @@ -0,0 +1,54 @@ | |||
| import fs from 'fs'; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have a few eslint warnings.
| const db = drizzle(process.env.DB_URI || '', { schema: pgSchema }); | ||
|
|
||
| describe('userTable', () => { | ||
| (process.env.DB_URI ? describe : describe.skip)('userTable', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why u need to change this.
Closes #167
Summary
system.versionexposing:versioncommitbuildDateAPP_VERSIONAPP_COMMITAPP_BUILD_DATEFASTAPI_PORTacross backend/CLI/docs/compose/workflow.Why
As requested in #167, admins need to identify exactly which app build is running, including commit SHA in Docker deployments.
Testing
APP_VERSION=1.2.3APP_COMMIT=abc1234APP_BUILD_DATE=2026-02-11T00:00:00Z/api/auth/sign-up/email/api/trpc/project.getCurrent/api/trpc/system.versionwith auth cookie and got:{"version":"1.2.3","commit":"abc1234","buildDate":"2026-02-11T00:00:00Z"}Notes